From 6f14d2668dc45b04b0f4c823c5f2e34d7cf62b53 Mon Sep 17 00:00:00 2001 From: Mollusk Date: Mon, 29 Jun 2026 02:24:53 -0400 Subject: [PATCH] docs(protocol): correct GOSSIP_PROTO version mapping (v5 = 0.6.0, not 0.7.0) The const comment claimed "v5 (0.7.0)" while GOSSIP_PROTO has been 5 since the v0.6.0 tag (introduced by bca2ccd, "release 0.6.0"). Git confirms the value went straight 3 -> 5 in that one release and a GOSSIP_PROTO == 4 build never existed. Merge the two mislabeled v4/v5 bullets into one accurate v4-v5 (0.6.0) entry and note the 3->5 jump + that this breaking gossip change correctly rode the 0.5.1 -> 0.6.0 MINOR bump per VERSIONING.md (0.6.1 is a wire-compatible PATCH, still proto 5). Comment-only; no wire/behavior change. Co-Authored-By: Claude Opus 4.8 --- src/protocol.rs | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/protocol.rs b/src/protocol.rs index 6eec650..aee7e7c 100644 --- a/src/protocol.rs +++ b/src/protocol.rs @@ -33,12 +33,16 @@ pub const FRIENDS_PROTO: u32 = 1; /// change is isolated into its own topic + signature domain so v2 and v3 peers /// never share a swarm. Resync everyone, exactly like the W4 avatar bump. /// -/// v4 (0.6.0): `PeerState` gained an optional `music` presence field carrying a -/// current shared-listening track descriptor and playback timeline. Bytes still -/// ride the files plane by id; gossip carries only the descriptor/timeline. -/// -/// v5 (0.7.0): `MusicPresence` gained optional prefetch hints for the next -/// track so tuned-in listeners can fetch it before the DJ advances. +/// v4–v5 (0.6.0): the W22 shared-listening / music presence work. `PeerState` +/// gained an optional `music` presence field (a current shared-listening track +/// descriptor + playback timeline; the audio bytes still ride the files plane by +/// id, gossip carries only the descriptor/timeline), and `MusicPresence` then +/// gained optional prefetch hints for the next track so tuned-in listeners can +/// fetch it before the DJ advances. Both shipped together in the **0.6.0** release +/// (commit `bca2ccd`), where the const advanced straight `3 → 5`: there was never +/// a `GOSSIP_PROTO == 4` build — 4 is a skipped step. (Per `VERSIONING.md` this +/// breaking gossip change rode the `0.5.1 → 0.6.0` MINOR bump, so the discipline +/// was honoured; 0.6.1 is a wire-compatible PATCH on top, still proto 5.) pub const GOSSIP_PROTO: u32 = 5; /// File-transfer plane version (chat attachment request/stream shape). Bump on /// any change. Mirrored in [`FILES_ALPN`].