From c82ab687627bbe5e38a125d1b583fa12fe08e161 Mon Sep 17 00:00:00 2001 From: mollusk Date: Thu, 7 Oct 2021 11:07:30 -0700 Subject: [PATCH] mkuser.sh: folow bash standards --- mkuser.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mkuser.sh b/mkuser.sh index ff86c6f..38a10b1 100755 --- a/mkuser.sh +++ b/mkuser.sh @@ -6,14 +6,14 @@ Create_user(){ echo echo -n "Username: " - read uname + read -r uname echo "Additional Groups: " echo echo "[1] - Arch Linux Defaults" echo "[2] - Void Linux Defaults" echo "[3] - Custom" - read dgroups + read -r dgroups if [ "${dgroups}" = "1" ];then addgroups="power, wheel, optical network, video, audio, storage" @@ -21,16 +21,16 @@ Create_user(){ addgroups="disk,wheel,storage,audio,video,optical,lp,network,dbus,xbuilder" elif [ "${dgroups}" = "3" ];then echo -n "Enter desired groups (comma separated): " - read custgroups + read -r custgroups addgroups="${custgroups}" fi echo "${addgroups}" - read -n 1 -p "wait" - useradd -m -g users -G "${addgroups}" -s /bin/bash ${uname} + read -r -n 1 -p "wait" + useradd -m -g users -G "${addgroups}" -s /bin/bash "${uname}" passwd "${uname}" echo - if [ -d /home/${uname} ];then + if [ -d /home/"${uname}" ];then echo "User ${uname} created" else echo "User creation failed" @@ -40,7 +40,7 @@ Create_user(){ Remove_user(){ echo echo -n "Username to delete: " - read duser + read -r duser userdel ${duser} if [ -d /home/${duser} ];then @@ -59,7 +59,7 @@ main(){ echo "[2] - Remove User" echo echo -n "Choose: " - read choice + read -r choice if [ "${choice}" = "1" ];then